Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend --names support for the import option #19

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Extend --names support for the import option #19

merged 5 commits into from
Dec 11, 2023

Conversation

Yousef-Majidi
Copy link
Contributor

Addresses #18

  • added a "skipped..." message for the user when the provided names don't match any Spaces
  • updated the final import message to reflect whether or not any spaces were imported:

"0 of x spaces imported..." --> "No spaces matched..."

  • added --names support for ImportSpaces
  • removed the import-inspector-collections method and all related components
  • updated the README.md to reflect the above changes

let me know if I've missed anything.

@frankkilcommins frankkilcommins self-assigned this Dec 11, 2023
frankkilcommins
frankkilcommins approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@frankkilcommins frankkilcommins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
@frankkilcommins frankkilcommins merged commit 8f2a0bb into SmartBear-DevRel:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankkilcommins frankkilcommins frankkilcommins approved these changes

Assignees

@frankkilcommins frankkilcommins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yousef-Majidi @frankkilcommins